Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy button in code fences doesn't work on macOS 10.14.6 #585

Closed
Rokt33r opened this issue Aug 14, 2020 · 5 comments
Closed

Copy button in code fences doesn't work on macOS 10.14.6 #585

Rokt33r opened this issue Aug 14, 2020 · 5 comments
Assignees
Labels
bug 🐛 Issue concerns a bug.
Projects

Comments

@Rokt33r
Copy link
Member

Rokt33r commented Aug 14, 2020

Running Boost Note 8.2 on macOS 10.14.6

The copy button is now there (from #560 I believe) but clicking it doesn't actually copy to my clipboard.

Either way I'm excited to see progress.

Originally posted by @meinenec in #315 (comment)

@Rokt33r
Copy link
Member Author

Rokt33r commented Aug 14, 2020

@meinenec I cannot reproduce the problem in my machine. Could you open dev tool and check any error logs when you click the copy button?

@Rokt33r Rokt33r added needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. bug 🐛 Issue concerns a bug. labels Aug 14, 2020
@sisoe24
Copy link

sisoe24 commented Aug 15, 2020

didn't want to open a new issue but currently the copy button doesn't work on any platform unless type the code is in triple backtick quotes with a language name.

Screen Shot 2020-08-15 at 11 32 50 AM

Boostnote 0.8.2
Platform: macOS 10.14.06, Kubuntu 20.04, Windows 10 2004

@meinenec
Copy link

@Rokt33r No new items get logged to the console when I click copy, but on launch I see two items.

A warning:

react-i18next:: i18n.languages were undefined or empty undefined
A	@	bundle.js:2

and an error:

TypeError: l is not a function
    at y (bundle.js:1411)
    at t.a.init (bundle.js:1411)
    at Dr (bundle.js:1411)
    at bundle.js:1411
    at Array.map (<anonymous>)
    at bundle.js:1411
    at bundle.js:1315
    at is (bundle.js:2)
    at gl (bundle.js:2)
    at t.unstable_runWithPriority (bundle.js:2)
(anonymous)	@	bundle.js:1315

@sisoe24 Good catch. I tested and found the same results. when I add the language to the triple backticks, it works. The other two still do not copy.

@Rokt33r
Copy link
Member Author

Rokt33r commented Aug 28, 2020

Confirmed. I'll fix it in this weekend.

@Rokt33r Rokt33r removed the needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. label Aug 28, 2020
@Rokt33r Rokt33r added this to To do (High) in Dev kanban Aug 28, 2020
@Rokt33r Rokt33r moved this from To do (High) to This sprint in Dev kanban Nov 28, 2020
@Rokt33r Rokt33r self-assigned this Nov 28, 2020
@Rokt33r Rokt33r closed this as completed Jan 9, 2021
@Rokt33r
Copy link
Member Author

Rokt33r commented Jan 9, 2021

It's already fixed!

@Rokt33r Rokt33r moved this from This sprint(Dec 12th - Dec 26th) to Done in Dev kanban Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
No open projects
Dev kanban
  
Done
Development

No branches or pull requests

3 participants