Enable context menu for thread with replies #1523
Conversation
Change behaviour of delete when thread has replies
Komediruzecki
force-pushed
the
feature/enable-context-menu-on-thread-with-replies
branch
from
94c52e9
to
4b03ea7
Compare
Rokt33r
force-pushed
the
feature/enable-context-menu-on-thread-with-replies
branch
from
4b03ea7
to
9539b92
Compare
| <div className={className}> | ||
| <CommentListContainer className={className}> | ||
| {initialComment == null && ( | ||
| <div className={'deleted_initial_comment'}> |
There was a problem hiding this comment.
lets not abuse brackets for strings
<div className='deleted_initial_comment'>
className feels a bit overkill to me
comment--deleted would be simpler and maybe more reusable.
|
|
||
| return threadComments[0].user | ||
| }, [threadComments, user]) | ||
|
|
||
| const submitComment = useCallback( |
There was a problem hiding this comment.
the naming irks me a bit. We are not submitting a new comment
we are submitting an update to the thread's initial/first comment.
updateThreadOpener or something would be more intuitive
| return | ||
| } | ||
|
|
||
| if (thread.initialComment == null || replyCount === 0) { |
There was a problem hiding this comment.
I am a bit confused by this logic here.
so a user will still be to completely delete threads that have replies?
They just need to remove their initial comment and then delete again for the thread itself? If we want to mimic slack it is not correct.
It should be back end logic.
in the front end: always send deleteComment
in the backend: delete comment, if thread affiliated has no more comments, remove thread.
There was a problem hiding this comment.
The onThreadDelete is fired when user can click on trash button, but the button itself is shown only if there are no replies (or initial comment was not yet deleted - in this case it will be), so no, user cannot do this afaik.
If the initial comment was deleted, you can see the trash icon only if number of replies is zero.
User needs to have 0 replies nevertheless of inital comment being removed, if it is not, it will remove the initial comment, not the thread
| threadOpenedUser != null && user != null && threadOpenedUser.id == user.id | ||
| if (thread.initialComment == null) { | ||
| return ( | ||
| <div className={'comment__meta__actions'}> |
| )} | ||
| </div> | ||
| ) : ( | ||
| <div className={'thread__comment__line'}> |
| </div> | ||
| ) : ( | ||
| <div className={'thread__comment__line'}> | ||
| <span>{thread.contributors[0].displayName}</span> |
There was a problem hiding this comment.
comments have set null on user, so contributors could be an empty array.
| }) => { | ||
| const { translate } = useI18n() | ||
| return ( | ||
| <div className={'thread__comment__line_more_replies_container'}> |
There was a problem hiding this comment.
unnecessary brackets,
className should be simplified
thread__comment__replies
Change behaviour of delete when thread has replies
Add deleted initial comment handling
Showcase:
ContextMenuForThread_2022-02-24.17-19-08.mp4
TODO:
Best to merge this after thread updates are fixed and reactions are merged
Also features a fix for comment sorting so its easier to track the this feature (change will be nulled when that PR is merged)