Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emoji support #374

Merged
merged 3 commits into from Apr 2, 2020
Merged

Add Emoji support #374

merged 3 commits into from Apr 2, 2020

Conversation

AWolf81
Copy link
Contributor

@AWolf81 AWolf81 commented Mar 14, 2020

Issue #245

Description
I've added remark-emoji.

An example markdown is:

Hey there :+1:

I :heart: Emojis

Which renders like this:
grafik

Tested

  • Windows 10 64bit Desktop (working)
  • Linux Ubuntu (test outstanding)
  • MacOS (I need help here - I don't have a Mac here)
  • Dev mobile (working)
  • WebApp (working)
  • Emojis from https://markdown-it.github.io/ rendering (except shortcodes)

Notes

  • Emoticons like :-) are not supported. I'll check if remark-emoticon could be used. OK, I've checked this and remark-emoticon is not what I want to use - adding own images is too complicated. retext-emoji is better than remark-emoji and also supporting short-codes like :-) (see demo). But I couldn't get remark2retext to work. I think I'll write a remark-plugin that is using emoticon for shortcode handling. Or am I missing something?
  • Emoticons will be supported with an update of remark-emoji. If the following PR is merged.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2020

CLA assistant check
All committers have signed the CLA.

@AWolf81 AWolf81 marked this pull request as ready for review March 14, 2020 15:13
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks for this PR.

@AWolf81
Copy link
Contributor Author

AWolf81 commented Mar 17, 2020

@ZeroX-DG Thanks for approving. I've updated remark-emoji. With the new version Emoticons are supported.
Like in the follwing codesandbox.

Is there a docs/help section for Boostnote.next? I'd like to check if I can add some details about the feature.

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rokt33r Rokt33r added this to the v0.4.0 milestone Mar 25, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Mar 27, 2020

@AWolf81 I'll test this on Linux and macOS and try to merge this pr tomorrow.

@Rokt33r Rokt33r merged commit be44955 into BoostIO:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants