Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing Page Revamp #458

Merged
merged 7 commits into from May 10, 2020
Merged

Landing Page Revamp #458

merged 7 commits into from May 10, 2020

Conversation

jhdcruz
Copy link
Contributor

@jhdcruz jhdcruz commented May 6, 2020 •
edited

Description

Revamped the landing page StyledNoteDetailNoNote.

Additional Changes:

  • locales update to support some strings and different keybinds N|Enter.

Related Issue: #449, #133

Screenshot

image

Known Issues

  • Poor responsiveness against smaller screen sizes. ~<620px (Fixed in 3c6f350)
  • CN, HK, TW, possible wrong characters.
  • Possible grammar issues in all languages except enUS.

@jhdcruz jhdcruz marked this pull request as ready for review May 6, 2020 10:50
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label May 6, 2020
@jhdcruz jhdcruz closed this May 8, 2020
@jhdcruz jhdcruz reopened this May 8, 2020
@Rokt33r Rokt33r added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 10, 2020
@Rokt33r Rokt33r added this to the v0.5.0 milestone May 10, 2020
@Rokt33r Rokt33r merged commit 551e5a3 into BoostIO:master May 10, 2020
@Rokt33r
Copy link
Member

Rokt33r commented May 10, 2020

LGTM!

@Rokt33r Rokt33r mentioned this pull request May 10, 2020
Closed
@tim-kt
Copy link

tim-kt commented May 10, 2020

The german translation would be as follows:

'note.createKey': 'N',
'note.createKeyOr': 'oder',
'note.createKeyMac': 'unter Mac',
'note.createKeyWinLin': 'unter Windows/Linux',
'note.createkeymessage1': 'Um eine neue Notiz zu erstellen, drücke',

I'm not sure where note.createkeymessage3 is used, but if it's at the beginning of a sentence, the "um" should be capitalized: Um eine neue Notiz zu erstellen. If not, it's correct as it is right now.

Thanks so much for implementing this!

@jhdcruz jhdcruz deleted the landingPage-revamp branch May 10, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhdcruz @Rokt33r @tim-kt @ZeroX-DG