Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking/Unlocking state bug #2121

Closed
ZNielsen opened this issue Jun 22, 2018 · 4 comments
Closed

Locking/Unlocking state bug #2121

ZNielsen opened this issue Jun 22, 2018 · 4 comments
Labels
bug 🐛 Issue concerns a bug.

Comments

@ZNielsen
Copy link

Current behavior

The state of the lock/unlock icon can get stuck in an incorrect state

image

Expected behavior

Either the icon display is reset with the locking state, or the locking state stays consistent with what the icon indicates. Personally, I would prefer if the locked state stayed on if it was selected, that is, when leaving the split pane view, it would return to the edit view if it was locked

Steps to reproduce

  1. Click in the boostnote field to edit
  2. Click lock
  3. Enable dual pane view (I did so with the hotkey)
  4. Disable dual pane view (I did so with the hotkey)
    • Automatically goes back to rendered view (not the edit view)
  5. Icon shows it is locked, when it is not.
  6. Repeat to switch the icon back to correct

Environment

  • Version : 0.11.6
  • OS Version and name : Windows10
@sosukesuzuki sosukesuzuki added the bug 🐛 Issue concerns a bug. label Jun 25, 2018
@ZNielsen ZNielsen changed the title Lockind/Unlocking state bug Locking/Unlocking state bug Jun 26, 2018
@IssueHuntBot
Copy link

@BoostIO funded this issue with $10. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@miguelalexbt has submitted a pull request. See it on IssueHunt

@Rokt33r
Copy link
Member

Rokt33r commented Jan 23, 2019

Fixed by #2661

@Rokt33r Rokt33r closed this as completed Jan 23, 2019
@IssueHuntBot
Copy link

@Rokt33r has rewarded $9.00 to @miguelalexbt. See it on IssueHunt

  • 💰 Total deposit: $10.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

No branches or pull requests

5 participants