Fixed lock button behavior and display

[miguelalexbt]

Description

Fixed the bug reported in #2121. Now, the locking state stays consistent when you change between split view and editor/preview view.
This created a new bug: after locking, changing to split view and changing back to editor/preview view, there would be no unlock icon, leaving the user "stuck" in the editor view. In order to fix that, I changed the line 22 of MarkdownEditor.js.
Finally, fixed a display bug where the lock button was still showing up in the split view.

Issue fixed

#2121

Type of changes

• 🔘 : Bug fix (Change that fixed an issue)
• ⚪ :Breaking change (Change that can cause existing functionality to change)
• ⚪ : Improvement (Change that improves the code. Maybe performance or development improvement)
• ⚪ Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• 🔘 All existing tests have been passed
• ⚪ I have attached a screenshot/video to visualize my change if possible

[ZeroX-DG]

The lock button doesn't seem to display for me anymore.

[miguelalexbt]

That's weird. Just tested on both Linux and Windows and it works perfectly. When does it happens?

[miguelalexbt]

Synced my fork with upstream and fixed what was probably causing that bug. Can you confirm if it's fixed?

[ZeroX-DG]

The lock button has now appeared but it appeared in the wrong way. It appear when the editor is in split view but when I change the mode and change it back, it's gone.

[miguelalexbt]

Found the problem: the lock button only works when using BLUR. Working on it.

[miguelalexbt]

My bad, completely forgot about being able to switch between preview/editor using double/right click. The issue should be fixed now (tested on both Linux and Windows).

[ZeroX-DG]

@miguelalexbt I found another bug. If you change from markdown note to a markdown note, the feature works great! But if you can it to a snippet note before changing to a markdown note, the lock button will disappear!

[miguelalexbt]

Should be fixed now. Also added the following line, so that the editor can be blurred right after opening the markdown note (before this change, the user first had to click the editor and only then he could blur and go to the preview). If you prefer, I can revert it. https://github.com/BoostIO/Boostnote/blob/7f6d4acf90753fc452c5ac16a5b1f559a1b4e95d/browser/main/Detail/MarkdownNoteDetail.js#L69

[ZeroX-DG]

Sorry for being late, LGTM 🎉 Thank you for your contribution.

[ZeroX-DG]

Although I still need @Rokt33r to review this