Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namefiles with extensions turn into links, "resize.sh" becomes a URL #2540

Closed
veloso11 opened this issue Oct 26, 2018 · 10 comments
Closed

namefiles with extensions turn into links, "resize.sh" becomes a URL #2540

veloso11 opened this issue Oct 26, 2018 · 10 comments
Labels
bug 🐛 Issue concerns a bug. feature request 🌟 Issue is a new feature request. rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded.

Comments

@veloso11
Copy link

veloso11 commented Oct 26, 2018

Issuehunt badges


IssueHunt Summary

amedora amedora has been rewarded.

Backers (Total: $20.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@ZeroX-DG
Copy link
Member

Haha such a silly bug 😄 , thank you for reporting.

@ZeroX-DG ZeroX-DG added the bug 🐛 Issue concerns a bug. label Oct 27, 2018
@IssueHuntBot
Copy link

@BoostIO funded this issue with $20. See it on IssueHunt

@kazup01 kazup01 added the bounty label Nov 7, 2018
@arcturus140
Copy link
Contributor

arcturus140 commented Nov 8, 2018

@kazup01 this is not a bug its a feature 😄. resize.sh is recognized as URL with the domain http://resize.sh/.

sh is the country code domain of Saint Helena.

it only works with valid country codes, like *.com, *.fr, *.it, which is intended. 🇺🇸 🇫🇷 🇮🇹
it does not work with invalid country codes, like *.ccc, *.abc, *.ss, which is also intended.

Consider this example:
test.sh

@arcturus140
Copy link
Contributor

@ZeroX-DG this should be a feature request IMO. Pretty sure I have a few manually typed links in my notes that would break otherwise.

@ZeroX-DG ZeroX-DG added the feature request 🌟 Issue is a new feature request. label Nov 11, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 11, 2018

In that case, can you make this feature optional? Or should we disable it forever? @arcturus140

@arcturus140
Copy link
Contributor

@ZeroX-DG I'll disable it forever

@Erroler
Copy link

Erroler commented Nov 12, 2018

A possible solution to implement is to make backslashes \ immediately before the file name prevent it from being shown as a link.

Example:

\file.sh -> not a link

file.sh -> link

@amedora
Copy link
Contributor

amedora commented Jul 21, 2019

This issue should be closed by #2540, or is there something to do in addition?

@ZeroX-DG
Copy link
Member

Nope, I'll close this, thanks @amedora

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 22, 2019

@kazup01 has rewarded $18.00 to @amedora. See it on IssueHunt

  • 💰 Total deposit: $20.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $2.00

@issuehunt-oss issuehunt-oss bot added the rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. feature request 🌟 Issue is a new feature request. rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded.
Projects
None yet
Development

No branches or pull requests

7 participants