Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust notification HotKeyTab #1010

Merged
merged 6 commits into from
Oct 25, 2017
Merged

Adjust notification HotKeyTab #1010

merged 6 commits into from
Oct 25, 2017
+11 −4

Conversation

PaulRosset
Copy link
Contributor

@PaulRosset PaulRosset commented Oct 24, 2017 •
edited

  1. Adjust position of notification in HotKeyTab

  2. Notification can disappear, to be more like a notification.
    Would like to but break some test. For the moment, deleted feature in commit below.

boostnotepr

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@kazup01 kazup01 self-requested a review October 25, 2017 01:28
kazup01
kazup01 approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit e7d9311 into BoostIO:master Oct 25, 2017
@kazup01
Copy link
Member

kazup01 commented Oct 25, 2017

Merged. Thank you for your contribution @PaulRosset !

@kohei-takata kohei-takata mentioned this pull request Oct 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PaulRosset @BoostnoteBot @kazup01