Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard markdown #1019

Merged
merged 3 commits into from
Oct 25, 2017
Merged

Add keyboard markdown #1019

merged 3 commits into from
Oct 25, 2017

Conversation

filoxo
Copy link
Contributor

@filoxo filoxo commented Oct 25, 2017

This feature solves #1015, adding kbd functionality by using <kbd></kbd> tags or [[]] syntax.

screen shot 2017-10-25 at 11 08 30 am
screen shot 2017-10-25 at 11 08 35 am
screen shot 2017-10-25 at 11 08 45 am

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@kazup01 kazup01 self-requested a review October 25, 2017 23:58
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@kazup01 kazup01 merged commit 88a828c into BoostIO:master Oct 25, 2017
@kazup01
Copy link
Member

kazup01 commented Oct 25, 2017

Thanks for your great contribution and cool design! @filoxo

@filoxo
Copy link
Contributor Author

filoxo commented Oct 26, 2017

@kazup01 Glad to have helped! I forgot to ask if you could add the Hacktoberfest label so that it's counted for that event. Thanks!

@filoxo filoxo deleted the add-keyboard-markdown branch October 26, 2017 00:23
@kazup01
Copy link
Member

kazup01 commented Oct 26, 2017

Added the Hacktoberfest label! And I added this feature to initial content. #1020 Thanks!

@kohei-takata kohei-takata mentioned this pull request Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants