Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added shortcut ctrl+q for quit and quit the app when using the Windows Close button #1043

Merged
merged 1 commit into from
Nov 5, 2017
Merged

added shortcut ctrl+q for quit and quit the app when using the Windows Close button #1043

merged 1 commit into from
Nov 5, 2017

Conversation

mslourens
Copy link
Contributor

Fixes #997

Changes:

  • added a shortcut (like mentioned in the comments of the issue) CTRL/CMD+Q to quit the app.
  • close the app (instead of minimize) when clicking the close button (could be changed in a setting in the future).

@kazup01
Copy link
Member

kazup01 commented Oct 31, 2017

Hi @mslourens , could you fix CI error?

@mslourens
Copy link
Contributor Author

I am not sure why CI failed with the error message:

An error occurred while generating the build script.

Can somebody who knows the build process have a look? I just fixed the lint warnings generated by my previous change.

@kazup01
Copy link
Member

kazup01 commented Nov 1, 2017

Hi @mslourens , thanks for your check! I could fix it when I restarted the CI. Sorry for your inconvenience.
We will check it at Sunday. Thanks! :)

@kazup01 kazup01 requested a review from sota1235 November 1, 2017 06:11
Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sota1235
Copy link
Contributor

sota1235 commented Nov 4, 2017

@kazup01 Can you confirm how this PR works? If it is fine, please merge it.

@kazup01 kazup01 merged commit 7c9fecd into BoostIO:master Nov 5, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 5, 2017

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application stays running after attempting to close (Windows 10)
4 participants