Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter on note filter #1052

Merged
merged 3 commits into from
Nov 9, 2017
Merged

Conversation

PaulRosset
Copy link
Contributor

  • Add counter to see how many notes are in the trash.

boostnotecounterdeletednotess

@kazup01
Copy link
Member

kazup01 commented Nov 2, 2017

Hi @PaulRosset , thank you for always your contributing!

I think that "All Notes" and Starred" also have this feature better than "Trash" alone.
How about do you think?

@BoostIO BoostIO deleted a comment from BoostnoteBot Nov 2, 2017
@PaulRosset
Copy link
Contributor Author

PaulRosset commented Nov 2, 2017

Hi @kazup01 !

Do you mean add a counter on "All notes" and "Starred" as well ?
I have implemented this features with all counter for each tab (all notes, starred and trash) on the last commit.
I find very useful to have counter especially for Trash and Starred notes.

@kazup01
Copy link
Member

kazup01 commented Nov 3, 2017

Hi @PaulRosset !
This(875c451) is exactly what I meant.
This feature is so useful! Thank you :) We will check it soon!

@kazup01 kazup01 requested a review from sota1235 November 3, 2017 04:04
@sota1235
Copy link
Contributor

sota1235 commented Nov 5, 2017

@PaulRosset
[Question] Why don't you show the number of each categories when the number is zero?

@PaulRosset
Copy link
Contributor Author

Hi @sota1235

This is my personal point of view, Less there is data on the UI more UI will fit for the user.
I prefer to use app which are pure.
So by adding always "0", it is an useless data for the user to know that.

@kazup01
Copy link
Member

kazup01 commented Nov 6, 2017

Hi @PaulRosset ! Thank you for your reply.
We think that it is better to show "0" because it is displayed in the case of Folder.
What do you think about it?

screen shot 0029-11-06 at 9 06 09 am

@PaulRosset
Copy link
Contributor Author

Oh ok, it make sense.
It is edited in the last commit.

@kazup01
Copy link
Member

kazup01 commented Nov 6, 2017

Thank you for your quick response and great support :) We will check it!

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 7, 2017
@kazup01 kazup01 self-requested a review November 9, 2017 06:33
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 8ef4852 into BoostIO:master Nov 9, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 9, 2017

Merged. Thank you for your contribution @PaulRosset 🎉

@kazup01 kazup01 removed the awaiting review ❇️ Pull request is awaiting a review. label Nov 9, 2017
@kazup01 kazup01 changed the title Add counter on deleted notes Add counter on note filter Nov 24, 2017
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 25, 2017

Hi @PaulRosset , I wrote your pull request to release note.
Thank you again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants