-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add counter on note filter #1052
Conversation
PaulRosset
commented
Nov 1, 2017
- Add counter to see how many notes are in the trash.
Hi @PaulRosset , thank you for always your contributing! I think that "All Notes" and Starred" also have this feature better than "Trash" alone. |
Hi @kazup01 ! Do you mean add a counter on "All notes" and "Starred" as well ? |
Hi @PaulRosset ! |
@PaulRosset |
Hi @sota1235 This is my personal point of view, Less there is data on the UI more UI will fit for the user. |
Hi @PaulRosset ! Thank you for your reply. |
Oh ok, it make sense. |
Thank you for your quick response and great support :) We will check it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged. Thank you for your contribution @PaulRosset 🎉 |
Hi @PaulRosset , I wrote your pull request to release note. |