enable importing file to empty folder #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I closed this PR by mistake. I reopen again. |
asmsuechan
reviewed
Nov 4, 2017
browser/main/NoteList/index.js
Outdated
| const storageKey = this.notes[targetIndex].storage | ||
| const folderKey = this.notes[targetIndex].folder | ||
| const storageKey = this.props.params.storageKey | ||
| const folderKey = this.props.params.folderKey |
There was a problem hiding this comment.
I guess this is better.
const { dispatch, location, params } = this.props
const { storageKey, folderKey } = params
asmsuechan
reviewed
Nov 4, 2017
asmsuechan
reviewed
Nov 4, 2017
Current implementation is fetching the import destination storageKey and folderkey from a file in the folder. If no files are in the folder, it cannot fetch these keys. Use prop.params.storageKey / folderKey instead.
…ating new note It makes less confusing for user.
yosmoc
force-pushed
the
importfiletoemptyfolder
branch
from
602b15e
to
8fb8c7a
Compare
|
Thanks for reviewing. I use the same storage/folder resolve way as creating a new note. I think this makes less confusing for user. Would you please review it again? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1057
Current implementation is fetching the import destination storageKey and folderkey from a file in the folder. If no files are in the folder, it cannot fetch these keys. Use prop.params.storageKey / folderKey instead.