replace selection with pasted image #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone with knowledge about the tests have a look at my failing build, because I don't know why it's failing, it succeeded on my pc. This test is failing |
|
@mslourens Thank you for your contribution! We will review this pull request! |
kohei-takata
suggested changes
Nov 14, 2017
There was a problem hiding this comment.
@mslourens Thanks for your PR, and please check the comment!
browser/components/CodeEditor.js
Outdated
| @@ -214,8 +214,7 @@ export default class CodeEditor extends React.Component { | |||
|
|
|||
| insertImageMd (imageMd) { | |||
| const textarea = this.editor.getInputField() | |||
There was a problem hiding this comment.
Could you delete this line?
textarea is not used I think.
kazup01
added
awaiting changes 🖊️
|
@kohei-takata I fixed my code according to your review comment, you can review it again. |
kazup01
added
awaiting review ❇️
|
Thank you @mslourens :) |
kazup01
added
next release (v0.8.17)
and removed
awaiting review ❇️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #1086 - only paste the created image tag over the current selection, not the start and end of the whole textarea.