Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix surrogate pairs garbling on folded SideNav #1184

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Fix surrogate pairs garbling on folded SideNav #1184

merged 1 commit into from
Nov 28, 2017

Conversation

cormoran
Copy link
Contributor

I fixed emoji garbling on folded sidebar.

Before:
2017-11-27 5 22 56

2017-11-27 5 23 07

After:
2017-11-27 5 26 21

sosukesuzuki
sosukesuzuki approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cormoran !
Thanks for your creating PR!
LGTM! 👍

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 27, 2017
@kazup01 kazup01 merged commit f0ed20e into BoostIO:master Nov 28, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 28, 2017

Thanks @cormoran! Wait for the next update :)

@kazup01 kazup01 added next release (v0.8.18) and removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Nov 28, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cormoran @kazup01 @sosukesuzuki @BoostnoteBot