Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm tag at onBlur event #1211

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

yosmoc
Copy link
Member

@yosmoc yosmoc commented Nov 30, 2017

Before

tag_before

After

tag_after

When user inputs the tag and leave the tag input box without fixing(enter or tab key), tag string is still there, but it is not stored as a tag.

This PR solves this problem. When the cursol is out of the tag input, it registers the current input contents as a tag.

When user inputs the tag and leave the tag input box without fixing(enter or tab key), tag string is still there, but it is not stored as a tag.

This changes solved this problem. When the cursol is out of the tag input, it registers the input as a tag.
@kazup01 kazup01 self-requested a review December 1, 2017 06:11
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 455b424 into BoostIO:master Dec 1, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 1, 2017

Thank you for your suggestion @yosmoc ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants