Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added border radius & background color to NavToggleButton #1236

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

Alaev
Copy link
Contributor

@Alaev Alaev commented Dec 4, 2017

At the moment when you hover the left menu icon its hard to see that you fully hovering it, yes there is a white color and a cursor icon I was thinking it would be useful to have a more visual effect

Folded out:
screen shot 2017-12-04 at 15 04 56

Folded in:
screen shot 2017-12-04 at 15 04 42

White theme:
screen shot 2017-12-04 at 15 02 42

At the moment when you hover the left menu icon its hard to see that you fully hovering it, yes there is a white color and a cursor icon I was thinking it would be useful to have a more visual effect
@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@Alaev Alaev changed the title Added border radius with background color Added border radius with background color to NavToggleButton Dec 4, 2017
@Alaev Alaev changed the title Added border radius with background color to NavToggleButton Added border radius & background color to NavToggleButton Dec 4, 2017
@kazup01 kazup01 self-requested a review December 4, 2017 13:28
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 31351e3 into BoostIO:master Dec 4, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 4, 2017

Looks great! Thanks for your contribution ;)
Are you UI designer? Particularly we are waiting for the UI improvement ideas.

@Alaev
Copy link
Contributor Author

Alaev commented Dec 4, 2017

@kazup01 Hey, I am a frontend dev, but I do love a good UI :))
I will try to add more stuff in my spare time.
Great app keep the good work!

@Alaev Alaev deleted the patch-1 branch December 4, 2017 14:49
@Alaev Alaev restored the patch-1 branch December 4, 2017 14:50
@kazup01
Copy link
Member

kazup01 commented Dec 4, 2017

@Alaev Wow I'm glad to hear that ;) Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants