-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed opening finder on Windows and Linux #1302
Conversation
fixes #1291 - tested on Ubuntu Linux Mate and Windows 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you edited this code on Windows, so line feed code has become CRLF.
please fix it.
@mslourens ! |
Hi @mslourens , thanks for your contribution. I can open a finder in master branch, but I can not open it in this one. Could you investigate it? environment Windows 10 |
On my Windows 10 laptop is the other way around: only with my changes am I able to open the Finder window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine
Merged. Thanks @mslourens 😊 Happy new year! |
fixes #1291 - tested on Ubuntu Linux Mate and Windows 10