Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking to other notes #1329

Merged
merged 1 commit into from
Dec 26, 2017
Merged

Conversation

robbawebba
Copy link
Contributor

This PR restores the ability to jump to other notes from links within markdown notes. This functionality was broken because we were routing to the hash of the currently visible note, rather than routing to the hash of the new note.

Thanks for the opportunity to help with a quick bug fix! What a great way to spend a flight 馃槃

Closes #1315

@kazup01 kazup01 self-requested a review December 25, 2017 19:27
@kazup01 kazup01 added the awaiting review 鉂囷笍 Pull request is awaiting a review. label Dec 25, 2017
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@kazup01 kazup01 merged commit 3127e85 into BoostIO:master Dec 26, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 26, 2017

@robbawebba Thanks for your awesome contribution. It makes many users happy!
Enjoy Boostnote :)

@kazup01 kazup01 added next release (v0.8.20) and removed awaiting review 鉂囷笍 Pull request is awaiting a review. Next Release labels Dec 26, 2017
@Rokt33r Rokt33r mentioned this pull request Jan 13, 2018
@kazup01
Copy link
Member

kazup01 commented Jan 13, 2018

Hi @robbawebba , thanks for your support! We were released v0.8.20.
Release Note
Enjoy Boostnote :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to snippet note not working
3 participants