Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elixir syntax highlighting #1354

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Elixir syntax highlighting #1354

merged 1 commit into from
Jan 4, 2018

Conversation

trinode
Copy link
Contributor

@trinode trinode commented Jan 1, 2018 •
edited

Syntax Highlighting for Elixir:

Things it should do:-

  • Highlighting in code editor
  • Highlighting in preview
  • Highlighting in snippets
  • Detect Elixir from .ex extension in a snippet file
  • Appear in the list of syntax types for manual selection
  • Apply when a code block is declared with ```elixir

Note

image

Snippet

image

@trinode trinode mentioned this pull request Jan 1, 2018
Closed
@trinode trinode changed the title Elixir highlighting in editor only Elixir highlighting in editor only (WIP - DO NOT MERGE) Jan 1, 2018
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Jan 1, 2018
@trinode trinode force-pushed the feature-elixir-support branch 3 times, most recently from eecee03 to 0a957c6 Compare January 1, 2018 15:59
@trinode trinode changed the title Elixir highlighting in editor only (WIP - DO NOT MERGE) Elixir syntax highlighting Jan 1, 2018
@trinode
Copy link
Contributor Author

trinode commented Jan 1, 2018

So I had this built a few times and it seems to randomly fail either LTS or stable, but only one, and not the same one each time... Is there some build issue somewhere?

sosukesuzuki
sosukesuzuki approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contributing!
LGTM:+1:

@trinode
Copy link
Contributor Author

trinode commented Jan 4, 2018

Awesome, thanks.

@kazup01 do we need to change the label from "In Review" so it will be merged? Are we in time for the next release?

@kazup01 kazup01 merged commit 4f02065 into BoostIO:master Jan 4, 2018
@kazup01 kazup01 added next release (v0.8.20) and removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Jan 4, 2018
@kazup01
Copy link
Member

kazup01 commented Jan 4, 2018

Merged. Thanks for your contribution @trinode :)
We will release it at v0.8.20!

@Rokt33r Rokt33r mentioned this pull request Jan 13, 2018
Merged
@kazup01
Copy link
Member

kazup01 commented Jan 13, 2018

Hi @trinode , thanks for your support! We were released v0.8.20.
Release Note
Enjoy Boostnote :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trinode @kazup01 @sosukesuzuki @BoostnoteBot