Fix permanently deleting note #1483
Conversation
- Permanently deleting note would not remove note from list until after refresh - Fix so permanently deleted note is removed list
|
thanks for your contributing. |
kazup01
added
awaiting changes 🖊️
|
I see, I will take a look! |
andyklimczak
force-pushed
the
delete-note
branch
from
3fbed87
to
dc03bb7
Compare
| @@ -200,6 +200,7 @@ class MarkdownNoteDetail extends React.Component { | |||
| } | |||
| ee.once('list:moved', dispatchHandler) | |||
| }) | |||
| .then(() => ee.emit('list:moved')) | |||
There was a problem hiding this comment.
The issue really is that dispatchHandler is never called. So we emit the event for the dispatch handler to be run.
I think this is better than just directly calling the dispatch handler (dispatchHandler()) because it remains asynch using the event emitter (I believe).
There was a problem hiding this comment.
I see. I think it is better than calling the dispatch handler.
but, if we delete a note in trash, Boostnote select nothing, like below.
this behavior is not we hope.
|
Updated and included small explanation. I'm not 100% sure if this is the best way, there are a few ways to solve this (by calling the dispatch handler) that seem to have subtle differences. Thanks! |
|
Updated to use |
|
Test failure seems like a flaky test (also seen happening here on master). Reran locally and passed. |
Rokt33r
added
next release (v0.9.0)
and removed
awaiting changes 🖊️
This bug was created in 9f9463f (git bisect), and I'm not sure of what review comments the commit message is referring to (looked through a few PRs around that time). So this fix might not be the fix we really want, depending on those comments.