Added option Empty Trash #1558
Merged
Added option Empty Trash #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rokt33r
approved these changes
Feb 23, 2018
Rokt33r
added
next release (v0.9.1)
and removed
awaiting review ❇️
|
Close #1555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request from #1555
I was contemplating to add a window to allow the user to "confirm" the deletion, but I think that wouldn't be needed since the user already technically "confirmed" that decision when deleting a single note beforehand. Apps nowadays don't really give the user any notification of emptying the trash anyways because 99% of the time the user never really empties the trash on accident. nor would the notes being deleted from the trash be of importance anyway, being the reason they got there in the first place