Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview images on editor #1633

Closed
wants to merge 14 commits into from
Closed

Preview images on editor #1633

wants to merge 14 commits into from

Conversation

forestail
Copy link
Contributor

This makes it possible to preview images on editor.

2018-03-04_23h48_24
2018-03-04_23h48_30

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Mar 5, 2018
@Rokt33r Rokt33r self-requested a review March 9, 2018 14:32
@Rokt33r
Copy link
Member

Rokt33r commented Mar 9, 2018 •
edited
Loading

@forestail This doesn't work on my mac. What should I do to see the preview?

And, could you fix the conflicts?

@forestail
Copy link
Contributor Author

@Rokt33r Sorry. I tested it on only MS-Windows.
I've fixed the suspicious codes and the conflicts. Would you please try it ?

@Rokt33r
Copy link
Member

Rokt33r commented Mar 15, 2018

@forestail I'll do it this weekends. Sorry for my late answer.

@Rokt33r
Copy link
Member

Rokt33r commented Mar 20, 2018

What should I do to see the preview?

I've tried it again. But, still have no idea how can I see the preview.

Is it supposed to display when hovering the image link??

@forestail
Copy link
Contributor Author

@Rokt33r I thought it was previewed when a image pasted.
But there are many bad codes, so I will withdraw my PR once.
I can't find the time now, so I'll review it later. Sorry.

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 4, 2018
ehhc
ehhc reviewed Apr 24, 2018
View reviewed changes
browser/components/CodeEditor.js
const lastline = editor.lineCount()
for (let i = 0; i < lastline; ++i) {
const lineValue = editor.getLine(i)
var imageMdRe = /\!\[.+\]\(\\:storage\\(.+?)\)/g
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not platform independent. I tried to develope something platform indepnendent in #1852

@Rokt33r
Copy link
Member

Rokt33r commented Apr 26, 2018

Close this now. Let us know when you can start working again. 😄

@Rokt33r Rokt33r closed this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehhc ehhc ehhc left review comments

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@forestail @Rokt33r @ehhc @kazup01