Fixed smart quotes when posting a note to blog #1691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lijinglue,
the default smart quote setting of
lib/markdown
wastrue
and didn't follow global config in ConfigManager. I have modifiedlib/markdown
to useconfig.preview.smartQuotes
value as default.markdown
instance was created at the beginning inNoteList/index.js
and never reloads, when user changesSmart Quotes
setting, markdown instance inNoteList/index.js
won't be updated.So I changed the markdown init behavior to only initiate when it's needed for
Post to Blog
feature.Before:
After: