Show confirmation dialog when deleting notes from the context menu #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set in preferences
sosukesuzuki
requested changes
Mar 31, 2018
browser/main/NoteList/index.js
Outdated
| @@ -574,22 +574,29 @@ class NoteList extends React.Component { | |||
| }) | |||
| } | |||
|
|
|||
| confirmDeleteNote (selectedNotes) { | |||
There was a problem hiding this comment.
This function is duplicated of it.
I want you to extract to browser/lib.
kazup01
added
awaiting changes 🖊️
sosukesuzuki
approved these changes
Apr 10, 2018
kazup01
added
awaiting review ❇️
|
Sorry for the delay things have been super busy irl. @sosukesuzuki Thank you for making those changes 👏 |
Rokt33r
approved these changes
Apr 16, 2018
Rokt33r
added
next release (v0.11.5)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1726
Delete confirmation dialog will show when deleting a note from the context menu when
Show a confirmation dialog when deleting notesis checked in preferences.