Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape html characters before convert to HTML #1753

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

nlopin
Copy link
Contributor

@nlopin nlopin commented Mar 25, 2018

Export to HTML used to export html-like text in the note as is. The content of the note could disappear because of that.

I've added a util function escapeHtmlCharacters and use it before export. The function convert symbols "'&<> to theirs html representation: &quot;, &#39;, etc.

Fixes #1728

@Rokt33r Rokt33r self-requested a review March 25, 2018 21:07
@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Mar 25, 2018
@sosukesuzuki sosukesuzuki self-requested a review March 31, 2018 08:39
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants