Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting of active tag #1759

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Fix highlighting of active tag #1759

merged 1 commit into from
Mar 31, 2018

Conversation

bimlas
Copy link
Contributor

@bimlas bimlas commented Mar 27, 2018

The currently selected tag was not highlighted in the list.

Before:

screencast

After:

screencast

@bimlas
Fix highlighting of active tag
254c881 
The currently selected tag was not highlighted in the list.

Before:

![screencast](https://i.imgur.com/6JsjYk7.gif)

After:

![screencast](https://i.imgur.com/xD6fc0c.gif)
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Mar 30, 2018
@sosukesuzuki sosukesuzuki self-requested a review March 31, 2018 07:57
sosukesuzuki
sosukesuzuki approved these changes Mar 31, 2018
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is me who implemented it.:pray:
I'm glad to you fix it!:smile:
LGTM:+1:

@sosukesuzuki sosukesuzuki removed the awaiting review ❇️ Pull request is awaiting a review. label Mar 31, 2018
@Rokt33r Rokt33r merged commit f6ad0a2 into BoostIO:master Mar 31, 2018
@bimlas bimlas deleted the fix-highlighting-of-active-tag branch April 1, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bimlas @sosukesuzuki @Rokt33r @kazup01