Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed change language in production mode #1764

Merged
merged 2 commits into from Apr 3, 2018
Merged

Fixed change language in production mode #1764

merged 2 commits into from Apr 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2018

Fixes #1761 (part 1)
Fixes #1727 (there are still *.pak files in locales folder, but .json files aren't necessary)

Tested with "grunt pre-build" on mac os 10.13.3 and win 10

@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Mar 29, 2018
@sosukesuzuki sosukesuzuki self-requested a review April 3, 2018 06:31
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@Rokt33r Rokt33r merged commit ac778d3 into BoostIO:master Apr 3, 2018
@ghost ghost deleted the languages-production branch April 4, 2018 17:30
@Rokt33r Rokt33r added next release (v0.12.0) and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants