Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut to toggle mode #1929

Merged
merged 2 commits into from May 24, 2018
Merged

Shortcut to toggle mode #1929

merged 2 commits into from May 24, 2018

Conversation

ZeroX-DG
Copy link
Member

@ZeroX-DG ZeroX-DG commented May 18, 2018

This feature has been requested here: #1699

This is the feature to allow user to toggle editor mode using a keyboard shortcut.

peek 2018-05-18 15-01

The default shortcut for toggling editor mode is ctrl+m. But user can still customize this at the hotkeys section in setting.

image

for developers

I have also added a shortcut manager, so if you want to create another shortcut in your next feature, just add it to the browser/main/lib/shortcut.js file like this:

'<nameOfTheFunction>' : () => { <function content> }

Then add your shortcut to the hotkey property in DEFAULT_CONFIG in browser/main/lib/ConfigManager.js file.

image

Remember the <nameOfTheFunction> that you added earlier must be the same as the <nameOfTheFunction> in the ConfigManager file.

For example here is my shortcut.js file

image

As you can see my function name is toggleMode and it's the same as the property in the ConfigManager file

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 18, 2018
@sosukesuzuki sosukesuzuki self-requested a review May 21, 2018 08:21
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!:smile:

@kazup01 kazup01 added next release (v0.11.6) and removed awaiting review ❇️ Pull request is awaiting a review. labels May 21, 2018
@washere
Copy link

washere commented May 23, 2018

This is badly needed. I suggest:

CTRL + T

To toggle On/Off.

T because: Ctrl + W Ctrl + E Ctrl + R are related functions.

@Rokt33r Rokt33r merged commit 67143ba into BoostIO:master May 24, 2018
@ZeroX-DG ZeroX-DG deleted the shortcut-mode branch May 24, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants