Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest Electron version (1.8.7) #1955

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

bimlas
Copy link
Contributor

@bimlas bimlas commented May 22, 2018

It inculdes security fixes, bug fixes and improvementts. See:
https://electronjs.org/releases

Reason for upgrading from 1.7.X to 1.8.X:

"We can not reasonably back port every bug fix and every feature to
older versions of Electron. 1.8.x is now a stable release line and if
you require this fix you should update to that stream."

electron/electron#9860 (comment)

PS.: I need this update to finish #192

@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 24, 2018
@sosukesuzuki
Copy link
Member

Please fix conflict. 🙏

@bimlas
Copy link
Contributor Author

bimlas commented May 28, 2018

Done.

It inculdes security fixes, bug fixes and improvementts. See:
https://electronjs.org/releases

Reason for upgrading from 1.7.X to 1.8.X:

"We can not reasonably back port every bug fix and every feature to
older versions of Electron. 1.8.x is now a stable release line and if
you require this fix you should update to that stream."

electron/electron#9860 (comment)
@bimlas
Copy link
Contributor Author

bimlas commented May 28, 2018

Sorry, I just rebased to older master, now I fixed the conflict.

@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels May 30, 2018
@Rokt33r Rokt33r merged commit 91a95b7 into BoostIO:master Jun 5, 2018
@Rokt33r Rokt33r added next release (v0.11.6) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 5, 2018
@bimlas bimlas deleted the update-electron branch June 5, 2018 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants