Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Apply translations on hardcoded strings and add missing translation to English #1983

Conversation

bimlas
Copy link
Contributor

@bimlas bimlas commented May 26, 2018

No description provided.

@bimlas bimlas changed the title I18n apply translations on hardcoded strings and add missing translation to English i18n: Apply translations on hardcoded strings and add missing translation to English May 26, 2018
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 26, 2018
@sosukesuzuki sosukesuzuki self-requested a review May 28, 2018 01:46
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!:+1:

@sosukesuzuki sosukesuzuki removed the awaiting review ❇️ Pull request is awaiting a review. label May 28, 2018
@sosukesuzuki sosukesuzuki merged commit aeb63ec into BoostIO:master May 28, 2018
@bimlas bimlas deleted the i18n-apply-translations-on-hardcoded-strings branch May 28, 2018 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants