Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of admonitions in Windows #2125

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Fix rendering of admonitions in Windows #2125

merged 1 commit into from
Jun 27, 2018

Conversation

johannbre
Copy link
Contributor

@johannbre johannbre commented Jun 25, 2018 •
edited

capture

@IssueHuntBot IssueHuntBot mentioned this pull request Jun 25, 2018
Closed
@sosukesuzuki sosukesuzuki added the awaiting review ❇️ Pull request is awaiting a review. label Jun 25, 2018
@sosukesuzuki
Copy link
Member

@johannbre Thanks for your contribution!:+1:
I want to try this pr on my local environment, but I don't have windows.
I'll put label "help wanted".

@sosukesuzuki sosukesuzuki added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Jun 25, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Jun 26, 2018

I'll review this.

@Rokt33r Rokt33r self-requested a review June 26, 2018 19:43
Rokt33r
Rokt33r approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Rokt33r Rokt33r merged commit 70d02e9 into BoostIO:master Jun 27, 2018
@Rokt33r Rokt33r added next release (v0.11.7) and removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting review ❇️ Pull request is awaiting a review. labels Jun 27, 2018
@johannbre johannbre deleted the admonition_bug_fix branch June 27, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johannbre @sosukesuzuki @Rokt33r