Improved dev script #2216
Merged
Improved dev script #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazup01
added
next release (v0.11.9)
awaiting review ❇️
Rokt33r
added
awaiting changes 🖊️
|
@Rokt33r done! |
Rokt33r
requested changes
Aug 9, 2018
package.json
Outdated
| "compile": "grunt compile", | ||
| "test": "PWD=$(pwd) NODE_ENV=test ava --serial", | ||
| "jest": "jest", | ||
| "fix": "eslint . --fix", | ||
| "lint": "eslint .", | ||
| "dev-start": "concurrently --kill-others \"npm run webpack\" \"npm run hot\"" | ||
| "dev-start": "node dev-scripts/dev.js" |
There was a problem hiding this comment.
Let's just go with dev rather than dev-start. This should be the last request. :)
|
@Rokt33r Again, done ! |
Rokt33r
added
next release (v0.11.9)
and removed
awaiting changes 🖊️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains improvement for the current
dev-startscript which can sometime start electron before the webpack bundle process is finished which then cause this: #2210Now on,
dev-startscript will wait for webpack bundle process to finish then run electron.