Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default language for snippet note #2352

Merged
merged 2 commits into from Sep 4, 2018
Merged

add default language for snippet note #2352

merged 2 commits into from Sep 4, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Aug 30, 2018

The change adds the option to define the default language of a new snippet code.
It should resolve #2349.

ZeroX-DG
ZeroX-DG approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. next release (v0.11.9) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Aug 31, 2018
@Rokt33r Rokt33r merged commit e11a68a into BoostIO:master Sep 4, 2018
@daiyam daiyam deleted the issue-2349 branch September 4, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to set default language for code snippet note?
3 participants
@daiyam @ZeroX-DG @Rokt33r