Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape Pipe character when inserting a URL into a table #2381

Merged
merged 2 commits into from
Sep 15, 2018

Conversation

Antogin
Copy link
Contributor

@Antogin Antogin commented Sep 7, 2018

Closes #2362

Before:
screen recording 2018-09-07 at 02 50 19 58 pm
After:
screen recording 2018-09-07 at 02 53 12 75 pm

Currently escapes | in titles at all times but the escape symbol will note be in the preview

@Antogin
Copy link
Contributor Author

Antogin commented Sep 7, 2018

@daiyam @OndragKlaus. Will this do?

@Antogin Antogin changed the title Pipe character not escaped when inserting a URL into a table [WIP] Escaped Pipe character when inserting a URL into a table [WIP] Sep 7, 2018
@Antogin Antogin changed the title Escaped Pipe character when inserting a URL into a table [WIP] Escape Pipe character when inserting a URL into a table [WIP] Sep 7, 2018
@klausondrag
Copy link

klausondrag commented Sep 7, 2018

@Antogin I actually like that this will influence the titles generated outside of tables too because the code is simpler and it makes it easier to copy/paste. Thanks for the quick bugfix.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Sep 9, 2018
@Antogin Antogin changed the title Escape Pipe character when inserting a URL into a table [WIP] Escape Pipe character when inserting a URL into a table Sep 9, 2018
@Rokt33r Rokt33r merged commit 03b8dbb into BoostIO:master Sep 15, 2018
@Rokt33r Rokt33r added next release (v0.11.10) and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants