Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export folder should also export the attachments -> fixes #2374 #2383

Merged
merged 1 commit into from
Dec 3, 2018
Merged

export folder should also export the attachments -> fixes #2374 #2383

merged 1 commit into from
Dec 3, 2018

Conversation

ehhc
Copy link
Contributor

@ehhc ehhc commented Sep 9, 2018

No description provided.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Sep 10, 2018
@ehhc ehhc mentioned this pull request Sep 26, 2018
Closed
@ehhc
Copy link
Contributor Author

ehhc commented Oct 8, 2018

@ZeroX-DG can you pleasae have a look at this :)

@jdewinne jdewinne mentioned this pull request Oct 9, 2018
Closed
@ehhc
Copy link
Contributor Author

ehhc commented Nov 28, 2018

@Rokt33r can you have a look at this PR? :)

@ZeroX-DG
Copy link
Member

Sorry for the delay, I look at this today.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 29, 2018 •
edited

Should we skip exporting empty note? Because if the note is empty your code will still export it to a .md file (the file has no name, just .md 😄 ) and it's empty.

@ehhc
Copy link
Contributor Author

ehhc commented Nov 29, 2018

@ZeroX-DG i think that's a separated problem. I didn't implemented the export feature, i just fixed that it can export the attachments as well..
So i think the problem of empty notes should be done independently :)

ZeroX-DG
ZeroX-DG approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 30, 2018
@Rokt33r Rokt33r merged commit 6c57ac8 into BoostIO:master Dec 3, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Dec 3, 2018
@ehhc ehhc deleted the exportMDexportsAttachments branch December 3, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehhc @ZeroX-DG @Rokt33r