Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #239 Fixes a bug which cannot open finder with using HotKey #240

Merged
merged 1 commit into from Jan 14, 2017
Merged

refs #239 Fixes a bug which cannot open finder with using HotKey #240

merged 1 commit into from Jan 14, 2017

Conversation

asmsuechan
Copy link
Contributor

Hi, I tried to fix however nothing thinking to fix it.

@sota1235
Copy link
Contributor

Thank you!!!! I'll check it!!!

@sota1235
Copy link
Contributor

I confirm bug is fixed. I'll release this code tonight. Thank you!!

@sota1235 sota1235 merged commit 13131a0 into BoostIO:master Jan 14, 2017
@sota1235
Copy link
Contributor

Related #239

@asmsuechan
Copy link
Contributor Author

asmsuechan commented Jan 14, 2017

Oops, should I add lib/finder-app.js to .eslintignore?

@sota1235
Copy link
Contributor

sota1235 commented Jan 14, 2017

I fixed by using inline comment.
ad4e50d

So, if you'll get same problem, please use ignore the code with inline comments!
http://eslint.org/docs/user-guide/configuring#disabling-rules-with-inline-comments

@asmsuechan
Copy link
Contributor Author

Wow! I didn't know. Thanks for this information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants