Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Toggle Editor Mode hotkey on OS X #2437

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Change Toggle Editor Mode hotkey on OS X #2437

merged 1 commit into from
Sep 30, 2018

Conversation

jacobherrington
Copy link
Contributor

By default the Toggle Editor Mode hotkey was set to Command + M,
which is a great and mnemonic hotkey. Unfortunately that hotkey
is also the hotkey to minimize an application.

This commit changes the default Toggle Editor Mode hotkey to
Command + Option + M on OS X, which will not minimize the window
and maintains the mnemonic pattern.

By default the Toggle Editor Mode hotkey was set to Command + M,
which is a great and mnemonic hotkey. Unfortunately that hotkey
is also the hotkey to minimize an application.

This commit changes the default Toggle Editor Mode hotkey to
Command + Option + M on OS X, which will not minimize the window
and maintains the mnemonic pattern.
@jacobherrington
Copy link
Contributor Author

This PR resolves #2361.

I disagree with #2361 on the default Show/Hide hotkey setting because I think that setting a hotkey so it doesn't conflict with other programs is on the user.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Sep 30, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG
Copy link
Member

I also agree with you about the show/hide Boostnote hotkey.

@ZeroX-DG ZeroX-DG added next release (v0.11.10) and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 30, 2018
@Rokt33r Rokt33r merged commit c47428b into BoostIO:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants