Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codemirror to fix centered column as not emoji #2443

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Sep 30, 2018

This change updates codemirror to fix the centered column of a table so it won't be recognized as an emoji.

| Left-aligned | Center-aligned | Right-aligned |
| :---         |     :---:      |          ---: |
| git status   | git status     | git status    |
| git diff     | git diff       | git diff      |

GFM reference

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 1, 2018
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:smile:

@sosukesuzuki sosukesuzuki added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 8, 2018
@Rokt33r Rokt33r added next release (v0.11.10) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 11, 2018
@Rokt33r Rokt33r merged commit a2bc1a5 into BoostIO:master Oct 11, 2018
@daiyam daiyam deleted the table-emoji branch October 11, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants