create note with selected tags

[daiyam]

This change creates a note with the tags selected in the SideNav.

[ZeroX-DG]

Should we add a checkbox to notify and allow users to not create a new note with selected tags?

[daiyam]

I could add an option so that new notes use the selected tags or not. Would it be ok?

[ZeroX-DG]

Yeah @daiyam that sounds good!

[daiyam]

here we go 😉

[ZeroX-DG]

Hey @daiyam is it me or your code causing this problem?

[daiyam]

@ZeroX-DG sadly, no. The issue is on master...

If you add console.log(location.pathname) at the top of the method tagListComponent(line 209) in the file /Boostnote/browser/main/SideNav/index.js, when you select the second tag, you will see in the console:

/tags/now hello
/tags/now%20hello
/tags/now%20hello
/tags/now%20hello

Beside the fact that the list is updated 4 times for 1 click, you can see that the spaces have been replaced by %20, so the code can't get individual tags (it splits on space...).

It happens since the merge Merge pull request #2484 from crakoucas/fix-electron-glibc-segmentation-fault (106caf2).
Maybe due to the newer electron...

[daiyam]

@ZeroX-DG I've made the PR #2600 to fix the issue on master.

[ZeroX-DG]

LGTM 🎉