Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix color for even rows in table #2506

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Oct 19, 2018

Description

This change fixes several bugs:

  • reset row index on blank line
  • separate even rows' colors for Solarized Dark and Solarized Light themes

Before:
screenshot

After:
screenshot

Issue fixed

#2505

Type of changes

[x] Bug fix (Change that fixed an issue)
[ ] Breaking change (Change that can cause existing functionality to change)
[ ] Improvement (Change that improves the code. Maybe performance or development improvement)
[ ] Feature (Change that adds new functionality)
[ ] Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

[x] My code follows the project code style
[ ] I have written test for my code and it has been tested
[x] All existing tests have been passed
[x] I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 19, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 21, 2018
@Rokt33r Rokt33r added next release (v0.11.11) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 23, 2018
@Rokt33r Rokt33r merged commit e550295 into BoostIO:master Oct 23, 2018
@daiyam daiyam deleted the fix-alt-color-table branch November 27, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants