Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag image into preview #2591

Merged
merged 2 commits into from
Dec 24, 2018
Merged

drag image into preview #2591

merged 2 commits into from
Dec 24, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Nov 9, 2018

Description

In preview mode, when dropping an image, the Editor is shown and the image in added at the end of the file on a new line.

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 10, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Although it would be nice if you can detect the drop position and insert it there 😄

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 13, 2018
@daiyam
Copy link
Contributor Author

daiyam commented Dec 13, 2018

@ZeroX-DG It could be done with the attribute data-line

@Rokt33r Rokt33r added next release (v0.11.13) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Dec 24, 2018
@Rokt33r Rokt33r merged commit aec79c4 into BoostIO:master Dec 24, 2018
@daiyam daiyam deleted the drop-image-preview branch December 24, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants