Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the auto-updating numbered list to the middle of a list #2598

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Fix the auto-updating numbered list to the middle of a list #2598

merged 1 commit into from
Jan 22, 2019

Conversation

richardtks
Copy link
Contributor

@richardtks richardtks commented Nov 10, 2018 •
edited

Description

Fix the problem where the user update the numbered to the middle of the list, the following number(s) did not updated.

Screenshot:
numberlist

Issue fixed

#2170

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@richardtks richardtks changed the title Fix the auto-updating numbered list to the middle of a list #2170 Fix the auto-updating numbered list to the middle of a list Nov 10, 2018
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 11, 2018
ZeroX-DG
ZeroX-DG approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 But I still need a review from @Rokt33r

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 14, 2018
@ZeroX-DG ZeroX-DG added the needs extra review 🔎 Pull request requires review from an additional reviewer. label Dec 16, 2018
@Rokt33r Rokt33r added awaiting review ❇️ Pull request is awaiting a review. and removed needs extra review 🔎 Pull request requires review from an additional reviewer. awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Dec 25, 2018
@Rokt33r Rokt33r self-requested a review December 25, 2018 03:45
@Rokt33r Rokt33r added next release (v0.11.13) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 22, 2019
@Rokt33r Rokt33r merged commit e43c7e9 into BoostIO:master Jan 22, 2019
@ZeroX-DG ZeroX-DG mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richardtks @ZeroX-DG @Rokt33r