Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when printing snippet #2637

Merged
merged 5 commits into from
Dec 3, 2018
Merged

Warning when printing snippet #2637

merged 5 commits into from
Dec 3, 2018

Conversation

miguelalexbt
Copy link
Contributor

Description

This PR only fixes the bug reported in #2026, as it doesn't implement any new feature (like printing snippets).
Now, when trying to print a snippet from the InfoPanel, it will show the same warning as when trying to print it from File->Print (instead of just showing an error in the console).

screenshot

Issue fixed

#2026

Type of changes

  • πŸ”˜ : Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ : My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ : All existing tests have been passed
  • πŸ”˜ : I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 24, 2018
@ZeroX-DG
Copy link
Member

The message seems to be wrong. Can you fix it too?

@ZeroX-DG ZeroX-DG added awaiting changes πŸ–ŠοΈ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 24, 2018
@miguelalexbt
Copy link
Contributor Author

Sure, I'll look into it.

@miguelalexbt
Copy link
Contributor Author

Added specific messages for each type of warning.

@ZeroX-DG
Copy link
Member

English is also my second language so I'm not sure if as a markdown note is correct. For me, I'll use in markdown notes which will become text export only available in markdown notes. What do you think?

@miguelalexbt
Copy link
Contributor Author

Seems good to me! Already changed it.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰ Thank you for your contribution

@ZeroX-DG ZeroX-DG added approved πŸ‘ Pull request has been approved by sufficient reviewers. and removed awaiting changes πŸ–ŠοΈ Pull request has been reviewed, but contributor needs to make changes. labels Nov 30, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved πŸ‘ Pull request has been approved by sufficient reviewers. labels Dec 3, 2018
@Rokt33r Rokt33r merged commit b224c72 into BoostIO:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants