Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed delete note not navigating to the next note #2651

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

ZeroX-DG
Copy link
Member

Description

This PR fixed the unwanted behavior when users delete a note. Instead of showing the create note message, the next note in the list will be displayed.
Before
boostnote_before

After
boostnote_after

Issue fixed

#2615, #2343

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 27, 2018
@ghost
Copy link

ghost commented Nov 28, 2018

@ZeroX-DG Well done!!!! Kudos!!!!!

@ghost
Copy link

ghost commented Nov 29, 2018

@ZeroX-DG I have tested this now with success and can confirm that it fixes the issue!

@ZeroX-DG
Copy link
Member Author

@infosisio great news!

@ZeroX-DG
Copy link
Member Author

ZeroX-DG commented Dec 1, 2018 via email

@ghost
Copy link

ghost commented Dec 3, 2018

@ZeroX-DG Yeah thanks a lot for fixing this. It was clearly the wrong behavior the way it was before.

@ghost
Copy link

ghost commented Jan 20, 2019

@ZeroX-DG Is there something pending with this? The code seems trivial and the issue annoying :)

@ZeroX-DG
Copy link
Member Author

@Rokt33r can you take a look at this PR? Thank you.

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 22, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r January 22, 2019 16:56
@Rokt33r Rokt33r added next release (v0.11.13) and removed needs extra review 🔎 Pull request requires review from an additional reviewer. approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 23, 2019
@Rokt33r Rokt33r merged commit a1deb15 into BoostIO:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants