Fix the search note functionality

[richardtks]

Description

Previously, the search will be executed only when the backspace key is entered. After the fix, the search start as soon as the user enter the character to the input.

Issue fixed

#2015

Type of changes

• 🔘 Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
• ⚪ Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• 🔘 All existing tests have been passed
• 🔘 I have attached a screenshot/video to visualize my change if possible

[ZeroX-DG]

I'm not familiar with this CompositionEvent so I'll also need review from @Rokt33r

[Rokt33r]

@richardtks I cannot confirm the problem yet. How did you reproduce the problem?

[Rokt33r]

@ZeroX-DG Can you reproduce the bug?

[richardtks]

@Rokt33r Hi, I able to reproduce by just simply typing the words that I want to search and it did not reflect on the list until I enter backspace.

I am using Ubuntu LTS 16.

[Rokt33r]

@richardtks Thanks. I'll try again in Ubuntu. 👍

[Rokt33r]

@richardtks Sorry for late response. I tried it on Ubuntu v18. It works fine. Which input system are you using?

[richardtks]

@Rokt33r, I am using ibus. What input system you are using?

[Rokt33r]

Hmm... that's weird. I'm using ibus too. Maybe should I check it with Chinese keyboard?

[richardtks]

@Rokt33r, weird, I am using ibus-chinese. maybe this only happens to ibus-chinese....

[Rokt33r]

I'm really afraid that this change might interfere with other input system with other languages and other OSs.... Hmm... give me more time to check all of them.

• Windows / Chinese
• Windows / Japanese
• macOS / Chinese
• macOS / Japanese
• Ubuntu / Japanese

[amedora]

resolved by #3037 already.

[ZeroX-DG]

Sorry @richardtks I'll have to close this PR. Thank you very much for the effort anyway ❤️