Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #2729 #2741

Merged
merged 1 commit into from
Dec 24, 2018
Merged

fixed issue #2729 #2741

merged 1 commit into from
Dec 24, 2018

Conversation

roottool
Copy link
Contributor

Description

I fixed the position of the checkbox shifted to the right.
I diverted the value of margin-left from the following code in line 77 of browser/components/markdown.styl.

li
  label.taskListItem
    margin-left -1.8em

Sample code

# Sample text

- [ ] test


- Normal UL
- [ ] Checkbox
  - [ ] test
  - test
- [x] Checkbox2
- Normal UL
- test
  > Quote in list element
- text2

> Normal Quote

- [ ] text
  > Quote in checkbox

  - test
    - [ ] test 
    - test
- [ ] text2

Before

before

After

after

Issue fixed

#2729

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • βšͺ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added awaiting review ❇️ Pull request is awaiting a review. approved πŸ‘ Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 23, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰ Thank you for your contribution

@Rokt33r Rokt33r merged commit cca5abd into BoostIO:master Dec 24, 2018
@Rokt33r Rokt33r added next release (v0.11.13) and removed approved πŸ‘ Pull request has been approved by sufficient reviewers. labels Dec 24, 2018
@roottool roottool deleted the fix-issue#2729 branch December 27, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants