allow menu bar visibility to be set in the settings

[richardtks]

Description

• Allow menu bar visibility to be set in the preferences.
• Allow the shortcut key to toggle menu bar visibility to be set in the hotkey.

Issue fixed

#2707

Type of changes

• ⚪ Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
• 🔘 Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• 🔘 All existing tests have been passed
• 🔘 I have attached a screenshot/video to visualize my change if possible

Screenshot:

• Show menu bar option
  

• Toggle menu bar visibility hotkey
  

[ZeroX-DG]

LGTM 🎉

[ZeroX-DG]

Works fine on Linux but I haven't tested it on window or mac. @richardtks which os you used to test this?

[richardtks]

@ZeroX-DG, I am using linux OS as well.

[Rokt33r]

I think menu bar should be shown by default. This looks a break change for me.

[richardtks]

@Rokt33r, if I am not mistaken, menu bar is invisible by default in linux os while menu bar in window is visible by default. Are you fine that menu bar should be visible by default across all the os?

[Rokt33r]

default in linux os

Could you tell me specific desktop env? Each desktop env has different behavior.

[ZeroX-DG]

@Rokt33r I think he's talking about this line of code:
https://github.com/BoostIO/Boostnote/blob/0289caad670fd8c3a8f8e1cac09fb1ca5c2e91fd/lib/main-window.js#L9
With the current code, the menu only show for Windows OS and it will be hidden on other OS unless the user press Alt.
https://github.com/BoostIO/Boostnote/blob/0289caad670fd8c3a8f8e1cac09fb1ca5c2e91fd/lib/main-window.js#L25

[Rokt33r]

Seems like I was confused by my old dirty code. LGTM now.