Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of USB drive will no longer cause irreparable damage. #2801

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

MiloTodt
Copy link
Contributor

@MiloTodt MiloTodt commented Jan 14, 2019

Description

Filters storages on init to filter out locations that not longer exist. Previously it would attempt to make a folder on whatever paths were there which would raise an exception if the drive was not connected.

User will need to restart Boostnote with the drive reinserted to access storage, but it will show up automatically on restart.

Cause was attempting to access a folder that does not exist, and also attempting to write a boostnote.json inside if there was not one already. This behaviour is fine on a local disk but not a missing external drive.

Issue fixed

fix #2799
Fix #2711

Type of changes

  • ✔️ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ✔️ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✔️ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ✔️ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 17, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jan 18, 2019
@Rokt33r Rokt33r merged commit 304b83b into BoostIO:master Jan 21, 2019
@Rokt33r Rokt33r added next release (v0.11.13) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 21, 2019
@MiloTodt MiloTodt deleted the issue-2799-add_storage branch March 15, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants