Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default editor font #1995 #2831

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Change default editor font #1995 #2831

merged 1 commit into from
Jan 28, 2019

Conversation

roottool
Copy link
Contributor

@roottool roottool commented Jan 25, 2019 •
edited

Description

I received this suggestion and changed default editor font of Windows and macOS.
result

Issue fixed

#1995

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 26, 2019
ZeroX-DG
ZeroX-DG approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 26, 2019
@Rokt33r Rokt33r merged commit 543c31c into BoostIO:master Jan 28, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Jan 28, 2019
@Rokt33r Rokt33r added this to the v0.11.14 milestone Jan 28, 2019
@roottool roottool deleted the change_default_editor_font#1995 branch January 29, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roottool @ZeroX-DG @Rokt33r