Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #2853 Allow "#" in title #2863

Merged
merged 1 commit into from
Feb 5, 2019
Merged

FIX #2853 Allow "#" in title #2863

merged 1 commit into from
Feb 5, 2019

Conversation

zzdjk6
Copy link
Contributor

@zzdjk6 zzdjk6 commented Feb 4, 2019 •
edited

Description

Allow "#" in title:

  • Only strip the leading # in the title
  • Make the finding title logic more straightforward

image

Issue fixed

#2853

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@zzdjk6 zzdjk6 changed the title FIX #2853 FIX #2853 Allow "#" in title Feb 4, 2019
@zzdjk6
FIX BoostIO#2853 Allow "#" in title
0f232b3 
- Only strip the leading # in the title
- Make the finding title logic more straightforward
- Add unit test
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 5, 2019
ZeroX-DG
ZeroX-DG approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 5, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r February 5, 2019 01:18
@Rokt33r Rokt33r added this to the v0.11.14 milestone Feb 5, 2019
@Rokt33r Rokt33r merged commit 54de57e into BoostIO:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer.
Projects
None yet
Milestone
v0.11.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzdjk6 @ZeroX-DG @Rokt33r